started implementing resolutions the TODO list #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…porting variables and handling JSON config parsing in bar.sh
Collaborator
Author
|
might as well give the clanker a shot |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements JSON configuration support and fixes issues with separator and custom_dir config options. It adds the ability to use config.json (when jq is available) as an alternative to the bash-based config file, and refactors the bar building logic to properly handle separators between modules.
Key changes:
- Added JSON config file support with automatic detection and preference when
jqis available - Exported SEPARATOR and CUSTOM_DIR variables to make them functional
- Refactored separator handling to use conditional logic instead of string truncation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
| dwmbar | Added JSON config detection logic and load_config() function to parse both JSON and bash configs, with periodic reloading |
| bar.sh | Added duplicate JSON config parsing logic and rewrote get_bar() to build the status bar with proper separator handling |
Collaborator
Author
|
TL;DR: duplication between |
…fixed the config dir with a slight discrepance, and added a new image showcasing the different seperators you can make
RobinHirst11
force-pushed
the
main
branch
2 times, most recently
from
cb0540e to
88251e6
Compare
Collaborator
Author
|
sorry lol... still getting the hang of this git shi |
thytom
approved these changes
Nov 23, 2025
Owner
thytom
left a comment
thytom
left a comment
There was a problem hiding this comment.
Looks good :) commits are good too.
thytom
pushed a commit
that referenced
this pull request
Nov 25, 2025
* fix: make separator and custom_dir config options actually work by exporting variables and handling JSON config parsing in bar.sh * feature: seperated archupdates into archupdates and archupdates-aur, fixed the config dir with a slight discrepance, and added a new image showcasing the different seperators you can make * fix: update todo file * fix: fix CI tests with aur seperated from pacman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently what I've changed:
fix: make separator and custom_dir config options actually work by exporting variables and handling JSON config parsing in bar.sh
implementation/fix: make the custom modules dir actually work
TODO:
make separate
archupdatesandarchupdates-aurmodulesparallelization/per-module delays